Draft
Conversation
i-am-tom
added
the
impact/no-changelog-required
tgummerer
reviewed
Apr 9, 2025
Comment on lines
+948
to
+950
| return "organization"; | ||
| } | ||
| return "pulumi-test"; |
Contributor
There was a problem hiding this comment.
I think these two are the wrong way around, no? If PULUMI_ACCESS_TOKEN is set we want to return pulumi-test by default, and return organization if it's not set at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a lot of experimenting, this has turned out to be very underwhelming - mostly just picking very specific versions of things and making stack names fully qualified in tests.