Conversation
micprog
requested changes
Aug 5, 2025
Member
micprog
left a comment
There was a problem hiding this comment.
Can we change this to add a define disabling the asserts rather than enabling them? I'd much prefer to have these enabled by default to propagate benefits rather than require users who want it to enable this feature. Adding a define to disable is OK IMO.
Member
|
After offline discussion, I believe the verilator error you are seeing is caused by a redefinition of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
OBI_ASSERT_ONdefine to shut down System Verilog assertions in theapb_2_obiIP. This became useful when simulating code with Verilator since it complains about:It is not exactly clear to me why it complains for this, at the beginning I was supposing that defaulted values in the assertion arguments (like
__desc = "") translated in Verilator hardcoding that argument to the default, not allowing an instance override. This does not seem to be the case, I think with other IPs (likestream_xbarin the common_cells) this problem does not appear because the assertions are all excluded by default.This might also be useful in synthesis.