Open
Conversation
Make the Ariane AXI config independent of the peripheral AXI Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
mp-17
reviewed
Nov 29, 2021
Contributor
mp-17
left a comment
mp-17
left a comment
There was a problem hiding this comment.
Thanks for the efforts, Nils! Great work, especially on CVA6's side! ;-)
Only not 100% clear why we are upsizing the I$ line width as well
| localparam int unsigned ICACHE_INDEX_WIDTH = $clog2(CONFIG_L1I_SIZE / ICACHE_SET_ASSOC); // in bit, contains also offset width | ||
| localparam int unsigned ICACHE_TAG_WIDTH = riscv::PLEN-ICACHE_INDEX_WIDTH; // in bit | ||
| localparam int unsigned ICACHE_LINE_WIDTH = 256; // in bit | ||
| localparam int unsigned ICACHE_LINE_WIDTH = 512; // in bit |
Contributor
There was a problem hiding this comment.
Do we need wider I$ lines as well?
| localparam int unsigned ICACHE_LINE_WIDTH = 512; // in bit | ||
| // D$ | ||
| - localparam int unsigned CONFIG_L1D_SIZE = 32*1024; | ||
| - localparam int unsigned DCACHE_SET_ASSOC = 8; // Must be between 4 to 64 |
Contributor
There was a problem hiding this comment.
Okay, this should be true by default, now
Contributor
|
@mp-17 Can we merge this? I guess it is more of a question of, is this the configuration you used for ASAP? |
mp-17
changed the title
Contributor
|
Let's rebase this, modify the changelog, and launch a backend run! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set Ariane's AXI data width to its data cache width (currently 512 bit)
Changelog
Changed
Checklist