Draft
Conversation
Before this commit, all the hazards (RAW, WAR, WAW) are handled by the operand requesters that throttle access to source reg elements. Even if the hazard is a WAR/WAW, the suboptimal but efficient way to deal with it is to slow down the source reg fetch. If an instruction does not have source regs, this cannot happen. For example, load instructions. Therefore, all the instructions that do not have vector source operands are stalled in the sequencer. Loads are super common, and stalling in the main sequencer means that all the instructions after the load are also stalled and cannot start their execution. Therefore, now they are processed, and the hazard check is done inside the VLDU. The write-back request is masked until there is no more any hazards on that load instruction.
Slide1Up/Down were blocked in the main sequencer when they had specific hazards. Now, these hazards are handled downstream, waiting for 1 cycle of stall and then continuing with the usual protocol. WAW hazards for widening instructions are also handled better now, discriminating between real widening instructions and reductions.
3 tasks
suehtamacv
approved these changes
Jan 23, 2023
Contributor
Author
|
The effect on IPC is not clear. Some kernels have worse performance. From a quick look, I see that the bank conflicts differ; but it seems to be more than that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #190
Handle slide1x and widening hazards with a special protocol
Slide1Up/Down were blocked in the main sequencer when they had specific
hazards. Now, these hazards are handled downstream, waiting for 1 cycle
of stall and then continuing with the usual protocol.
WAW hazards for widening instructions are also handled better now,
discriminating between real widening instructions and reductions.
Handle WAW and WAR
vloadhazards in theVLDUBefore this commit, all the hazards (RAW, WAR, WAW) are handled
by the operand requesters that throttle access to source reg elements.
Even if the hazard is a WAR/WAW, the suboptimal but efficient way to
deal with it is to slow down the source reg fetch.
If an instruction does not have source regs, this cannot happen. For
example, load instructions. Therefore, all the instructions that do
not have vector source operands are stalled in the sequencer.
Loads are super common, and stalling in the main sequencer means
that all the instructions after the load are also stalled and cannot
start their execution.
Therefore, now they are processed, and the hazard check is done inside
the VLDU. The write-back request is masked until there is no more any
hazards on that load instruction.
Changelog
Changed
vloadhazards in theVLDUChecklist