-
Notifications
You must be signed in to change notification settings - Fork 34
Add FP32 operators and tiling support for MicroLlama on Snitch #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lee2716
wants to merge
2
commits into
pulp-platform:devel
Choose a base branch
from
lee2716:devel
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 104
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 2170
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 832
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 47
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 47
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 47
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 3564
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 1241
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 94
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 94
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 47
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 706
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 412
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 8804
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 2043
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 368
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 3652
🏁 Script executed:
Repository: pulp-platform/Deeploy
Length of output: 6781
Stride calculation is broken for inputs with different ranks — fix required.
The stride computation in
AddParser.parseNodeCtxt(lines 494-525) fails when input shapes have fewer dimensions than the output shape. The code checksi < len(shape1)without padding shapes first, violating ONNX broadcasting semantics which pad shorter shapes with 1s on the left.For example,
shape1=[4]andout_shape=[2,3,4]producesstrides1=[0,0,0]instead of[0,0,1].The correct approach is already implemented in
Deeploy/Targets/Snitch/Parsers.py(SnitchAddParser._compute_broadcast_strides). Pad both shapes from the left before computing strides:if need_broadcast: # Calculate strides for broadcasting ndim = len(out_shape) + # Pad shapes from the left to match ndim (ONNX broadcasts from right) + padded_shape1 = [1] * (ndim - len(shape1)) + shape1 + padded_shape2 = [1] * (ndim - len(shape2)) + shape2 + # Compute strides for input 1 strides1 = [1] * ndim for i in range(ndim - 1, -1, -1): - if i < len(shape1) and shape1[i] == out_shape[i]: + if padded_shape1[i] == out_shape[i]: if i == ndim - 1: strides1[i] = 1 else: - strides1[i] = strides1[i + 1] * shape1[i + 1] if ( - i + 1 < len(shape1) and shape1[i + 1] == out_shape[i + 1]) else strides1[i + 1] + strides1[i] = strides1[i + 1] * padded_shape1[i + 1] if ( + padded_shape1[i + 1] == out_shape[i + 1]) else strides1[i + 1] else: strides1[i] = 0 # Broadcast dimensionApply the same fix to the
strides2computation below.🤖 Prompt for AI Agents