Explicitly specify loopback IP when exposing container ports #288
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common way ports are exposed in docker
-p 5432:5432is actually equivalent to-p 0.0.0.0:5432:5432, which binds the port to all of the host's IPs.Since docker bypasses local firewalls like
ufwandiptables(docker/for-linux#690) , a user that would follow our docs to setup a Postgres container on a VPS VM will inadvertently expose the Postgres port and container to the internet.To follow security best practices, this PR switches to a port notation that explicitly binds it to the host's loopback IP.