feat: Human Proof Section #489
Conversation
tipogi
left a comment
tipogi
left a comment
There was a problem hiding this comment.
Some missing points, passing to @MiguelMedeiros the UI review of the draft
| const requestLightningInvoice = React.useCallback(async () => { | ||
| try { | ||
| setIsLoading(true); | ||
| const invoice = await Homegate.requestLightningInvoice(); |
There was a problem hiding this comment.
Homegate is a service as you define but the organisms does not have access to the services. The only way to access to the services is through, controller and after application. So we are missing, a homegate controller and application. In that case, you will call to HomegateController.requestLightningInvoice().
| const codeValue = code.join(''); | ||
| try { | ||
| setIsVerifyingCode(true); | ||
| const result = await Homegate.verifySmsCode(phoneNumber, codeValue); |
There was a problem hiding this comment.
Same as the above code. HomegateController.verifySmsCode()
There was a problem hiding this comment.
This is a molecule, it does not have any interaction with data layer or/and external services. It is just an static component
There was a problem hiding this comment.
Leaving this open as we might need to add more logic there. US users might not be able to use LN payments.
| } | ||
|
|
||
| // Create new fetch promise | ||
| cachePromise = getSatoshiUsdRate() |
There was a problem hiding this comment.
The same reason as above, it has to access through the controller. I would add in the HomegateController another method to get that rate. The function should be renamed to fetchSatoshiUsdRate. The get prefix means that we get data from indexdb
| // Ignore if unmounted or superseded | ||
| if (activeRequestRef.current !== requestId || !isMountedRef.current) return; | ||
| try { | ||
| // TODO: Instead of going to the feed, this should go to the create profile page. |
There was a problem hiding this comment.
The merged PR already solves that one. If we signUp/signIn with the QR using ring, and that key does not signup in the app (it has to have profile.json file in the homeserver), we redirect to the creation of the profile.json
tipogi
left a comment
tipogi
left a comment
There was a problem hiding this comment.
nice UX! for my side, ready the core layer
Adds