Exclude generated files in docs/_build from the Python sdist#48
Merged
Exclude generated files in docs/_build from the Python sdist#48
docs/_build from the Python sdist#48Conversation
docs/_build from the Python sdist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to limitations in Poetry's
[tool.poetry]configuration block, there's no simple way to includedocs/in the sdist, while also excluding the generated files indocs/_build. The cleanest workaround is to removedocs/_buildbefore running thepoetry buildcommand. That's clearly a hack, but there's apparently no other alternative. Technically, this is only necessary for projects that build docs, but it's easiest to just always do the cleanup.