Update Emscripten example to work with the new 4.0 API.#1
Open
kblaschke wants to merge 2 commits intoprojectM-visualizer:masterfrom
Open
Update Emscripten example to work with the new 4.0 API.#1kblaschke wants to merge 2 commits intoprojectM-visualizer:masterfrom
kblaschke wants to merge 2 commits intoprojectM-visualizer:masterfrom
Conversation
kblaschke
commented
Jul 28, 2023
projectM_SDL_emscripten.cpp
Outdated
| projectm_set_aspect_correction(app.projectM, true); | ||
| projectm_set_easter_egg(app.projectM, 0); | ||
|
|
||
| projectm_set_preset_switch_failed_event_callback(app.projectM, &presetSwitchFailedEvent, nullptr); |
Member
Author
There was a problem hiding this comment.
For now I'm redirecting the preset switch failed event to the app itself to prevent the playlist from spamming preset switches. The playlist manager will then only handle preset switch requests once.
A similar thing could be done by setting retries to 0, but can't properly log the failure then.
|
Having some trouble building this branch. I followed the install steps here https://emscripten.org/docs/getting_started/downloads.html Then followed the build steps in the Readme here I think the Readme needs to be updated. Those commands are missing
I am not seeing these artifacts. Should I Then should I build the example? I tried a few things to for presets in the build but no luck. |
|
Also tried against https://github.com/kblaschke/projectm/tree/gles-fixes and same errors... |
|
Aha! Hardcoding presets got me further noah@studio build % git diff emscripten
diff --git a/CMakeLists.txt b/CMakeLists.txt
index c5b406d..cd48bc5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -30,5 +30,5 @@ target_link_options(projectM_SDL_emscripten
"SHELL:-s MAX_WEBGL_VERSION=2"
"SHELL:-s FULL_ES2=1"
"SHELL:-s ALLOW_MEMORY_GROWTH=1"
- "SHELL:--preload-file ${PRESETS_DIR}@/presets"
+ "SHELL:--preload-file /Users/noah/src/projectM/projectm/presets"
) |
|
Now on to debugging errors in the browser. 
|
|
Still not able to get this to work. Builds are going well with However loading the resulting build is giving errors in the javascript console: I tweaked the html a little bit to wait for user interaction before trying to use the audio context but that hasn't helped. I did actually get this running once, but I don't recall the exact emscripten or projectm versions. |
|
This works against projectm version projectM-visualizer/projectm@8461bb9 So something in projectM-visualizer/projectm#741 broke it |
Member
Author
|
There's something going wrong when switching/loading presets as far as I could tell. I sadly didn't found the time yet between Christmas parties and curing a bad flu to look further into it or even merge my other open PRs. Hopefully will get this resolved in early January. If you can find out more until then, that's highly appreciated. |
|
@nzoschke Got further? |
|
On the emcmake command, I modified it to include |
Member
Author
|
@fucksophie The proper variable to pass to CMake would be
I'm also a bit confused about the |
Member
Author
|
Noticed I had a few changes lying around for a while, pushed them. Build works with latest libprojectM dev versions. Here's the build result for demonstration purposes. Audio capturing is still wonky, sometimes it works, sometimes not. Guess this is a browser thing, or some issue with the web audio API and emscripten. @blaquewithaq You expertise with browser audio capturing might come in handy in that regard! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically replaced everything which was renewed with the API update and used the emscripten main loop with argument to pass in the static app object.