-
Notifications
You must be signed in to change notification settings - Fork 4
Feature(authentication): add Linux support using zbus and polkit #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature(authentication): add Linux support using zbus and polkit #5
Conversation
- Replace polkit and gio dependencies with zbus and zbus_polkit - Implement D-Bus-based authentication for Linux using polkit - Add complete Linux implementation module with proper error handling - Add Tyrese Luo as co-author to authentication crate - Update example to handle Linux async authentication pattern - Add comprehensive Linux usage documentation to README - Enable Linux target in sys.rs module
…tweaks - note Linux action ID requirement in example and expose PolicyBuilder::action_id on Linux - cache system bus and polkit authority, name auth thread, refine authorization result handling - make authentication Error clonable for reuse in cached results
kevinaboos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tyrese, I really appreciate this contribution!
I left a few comments about documentation style/location, but the most important questions I have are about the proper way to determine what kind of authentication error occurred. Doing a string search of the error message cannot possibly be the correct way.
Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>
Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>
Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>
…to add_authentication_for_linux
PR content
Add Linux support using zbus and polkit for authentication crate and clear the database errors under Linux.
The basic Linux authentication pop-up has been implemented, but some details still need to be confirmed.
Still in development, with an update coming this week.
PR Changes