Approve FS-0007: v0 Two-Client Multiplayer Slice#10
Merged
danieldilly merged 1 commit intomainfrom Dec 23, 2025
Merged
Conversation
Changes spec status from Draft to Approved after extensive iterative review. Key refinements in this version: - Complete wire schemas (ClientHello, ServerWelcome, JoinBaseline, SnapshotProto) - Explicit detectability data contract with tie evolution semantics - ServerWelcome.target_tick_floor formula normative requirement - Byte-identical snapshot broadcast for v0 floor coherency - InputSeq selection with max_seq_tied as single normative trigger - Buffer cap lifted to own validation row for visibility - Floor recovery test (T0.13a) validates bounded recovery under packet loss - Transport vs application monotonicity clarification - 20 Tier-0 gates with concrete acceptance criteria Constitution updates: - AC-0001.1: Testable synchronization definition - AC-0001.2: Controlled entity binding requirement ADR updates: - ADR-0006: v0 floor coherency normative constraint Spec is implementation-ready with no remaining P0 blockers. Refs: #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Approves FS-0007 v0 Two-Client Multiplayer Slice specification after extensive iterative review with multiple senior reviewers. Changes spec status from Draft to Approved, marking it implementation-ready.
Key refinements:
Trace Block
Files Changed
docs/specs/FS-0007-v0-multiplayer-slice.md(status: Draft → Approved; +263/-57 lines)docs/constitution/acceptance-kill.md(AC-0001 clarifications: testable synchronization definition, entity binding requirement)docs/adr/0006-input-tick-targeting.md(added v0 floor coherency normative constraint)docs/networking/v0-parameters.md(minor parameter documentation updates)Determinism / Simulation Impact
Verification
just ci(all checks pass)just ids(Constitution ID validation passes)just spec-lint(FS-0007 structure and ID references validated)just ids-genrun and outputs committed (AC-0001 updates)Risk / Notes
Spec Completeness: This spec underwent extensive review with multiple senior reviewers across 20+ refinement rounds. All P0 blockers closed:
Implementation Next Steps: Once merged, implementation work for AC-0001 can begin using this approved spec as the definitive requirements document.
Spec Length: 554 lines. Reviewer feedback noted this feels long due to Constitution material repetition. Post-v0 refactor tracked to move stable patterns into Constitution and shrink specs to deltas only. Not blocking for v0.
Checklist