This repository was archived by the owner on Jul 29, 2020. It is now read-only.
Fix insertTableNameQuotesRegex to support hyphen in dbname#54
Open
sarath16933 wants to merge 2 commits intoprest:masterfrom
Open
Fix insertTableNameQuotesRegex to support hyphen in dbname#54sarath16933 wants to merge 2 commits intoprest:masterfrom
sarath16933 wants to merge 2 commits intoprest:masterfrom
Conversation
Signed-off-by: Sarath <sveedu@akamai.com>
|
Hello, @sarath16933! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
Signed-off-by: Sarath <sveedu@akamai.com>
avelino
suggested changes
Jul 20, 2020
Member
avelino
left a comment
avelino
left a comment
There was a problem hiding this comment.
we need to write test for these regex
Member
|
ping @sarath16933 |
Member
|
@sarath16933 we are in the process of centralizing the repository to simplify the contribution and maintainability of pREST. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarath sveedu@akamai.com
Fixes: prest/prest#369