Open
Conversation
roya2yush
commented
Jan 23, 2024
roya2yush
commented
- Sleeping for 60 seconds and Recalling run.py if node was successfully drained
- This will create a new action plan according to all the pods that are now scheduled in some other node
- And use that information to try and fit pods into nodes and delete the redundant one.
justjkk
reviewed
Jan 25, 2024
| status = drain_node(cluster, node_name, action_plan_path, 'False', dry_run) | ||
| if status and dry_run == 'False': | ||
| time.sleep(60) # Sleep for 60 seconds | ||
| subprocess.run(["python3", "run.py", "-c", cluster, "-l", label_name, "-v", label_value, "--log", log_level, "--dry_run", dry_run]) |
There was a problem hiding this comment.
@roya2yush Better to use a while loop and a max retries counter so that this doesn't run forever forking a new process every 60 seconds and consuming all the RAM or running out of max processes (32,768 in about 23 days).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.