Pass SFXKey through sync for glide #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eupharis
requested review from
aarongoin
and removed request for
eneumann and
eupharis
Member
|
removing myself and eric for review. we are under a time crunch! can we wait for aaron to review on thurs? |
aarongoin
reviewed
Dec 19, 2025
Member
aarongoin
left a comment
aarongoin
left a comment
There was a problem hiding this comment.
Okay this looks good! Sorry for the delay, was waiting for Lance's PR to merge to unblock yours.
Just a couple things left to actually prep these changes for deploy to dev:
- Bump the version of the library in the package.json to say: 0.25.11
- npm install --ignore-scripts to update the lock file.
- Commit updates to this PR
This will trigger the deployment of these changes once we merge this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding arg for sync command to accept execution API Key for server functions - to be added to deploy action for glide