add authData to polyCustom with typings
#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lellimecnar
commented
Dec 11, 2025
templates/index.d.ts.hbs
Outdated
Comment on lines
81
to
85
| tenant: schemas.Tenant; | ||
| environment: schemas.Environment; | ||
| application: schemas.Application | null; | ||
| user: schemas.User | null; | ||
| permissions: schemas.Permissions; |
Contributor
Author
There was a problem hiding this comment.
Is this the correct understanding of what the schemas type contains?
Member
There was a problem hiding this comment.
No, schemas is an autogenerated thing in the SDK. We probably need to make explicit types of these things in here pulling from the types we find in poly-alpha.
Contributor
Author
There was a problem hiding this comment.
How about this?
interface AuthData {
// ...
tenant: poly.Oob.Polyapi.Tenant.Get.ReturnType;
environment: poly.Oob.Polyapi.Environments.Get.ReturnType;
application: poly.Oob.Polyapi.Applications.Get.ReturnType | null;
user: poly.Oob.Polyapi.Users.Get.ReturnType | null;
permissions: poly.Oob.Polyapi.PermissionPolicies.Get.ReturnType;
// ...
}
aarongoin
reviewed
Dec 12, 2025
templates/index.d.ts.hbs
Outdated
| export type schemas = schemas.Schemas | ||
|
|
||
| interface AuthData { | ||
| key: string; // unencrypted api key |
Member
There was a problem hiding this comment.
Per my other comments about not passing along the actual api key: let's remove this line form the type.
Suggested change
| key: string; // unencrypted api key |
aarongoin
reviewed
Dec 12, 2025
Member
aarongoin
left a comment
aarongoin
left a comment
There was a problem hiding this comment.
Okay, just a few changes to be made here, nothing crazy.
Also we'll want to:
- Bump the version of the library in the package.json to say:
0.25.10 npm install --ignore-scriptsto update the lock file.
This will trigger the deployment of these changes once we merge this branch.
aarongoin
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthDatainterfaceauthDatatoPolyCustominterface{}