Skip to content

Removed duplicate ORs #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-Estoll wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Removed duplicate ORs #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polyapi/poly_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def update_one(*, id: str, where: Optional[{table_name}WhereFilter], data: {tabl
@staticmethod
def update_one(*args, **kwargs) -> {table_name}Row:
if args:
if len(args) != 2 or or not isinstance(args[0], str) not isinstance(args[1], dict):
if len(args) != 2 or not isinstance(args[0], str) or not isinstance(args[1], dict):
raise TypeError("Expected id and query as arguments or as kwargs")
query = args[1]
if not isinstance(query["where"], dict):
Expand Down Expand Up @@ -356,7 +356,7 @@ def delete_one(*, where: Optional[{table_name}WhereFilter]) -> PolyDeleteResult:
@staticmethod
def delete_one(*args, **kwargs) -> PolyDeleteResult:
if args:
if len(args) != 2 or or not isinstance(args[0], str) not isinstance(args[1], dict):
if len(args) != 2 or not isinstance(args[0], str) or not isinstance(args[1], dict):
raise TypeError("Expected id and query as arguments or as kwargs")
query = args[1]
if not isinstance(query["where"], dict):
Expand Down
6 changes: 3 additions & 3 deletions tests/test_tabi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class MyTableRow(TypedDict, total=False):
active: Required[bool]
""" Required property """

optional: dict[str, Any]
optional: Dict[str, Any]
Copy link
Member

@aarongoin aarongoin Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs reverted for now. See https://github.com/polyapi/poly-alpha/issues/5022 which is a ticket for resolving these type issues.




Expand Down Expand Up @@ -295,7 +295,7 @@ def update_one(*, id: str, where: Optional[MyTableWhereFilter], data: MyTableSub
@staticmethod
def update_one(*args, **kwargs) -> MyTableRow:
if args:
if len(args) != 2 or or not isinstance(args[0], str) not isinstance(args[1], dict):
if len(args) != 2 or not isinstance(args[0], str) or not isinstance(args[1], dict):
raise TypeError("Expected id and query as arguments or as kwargs")
query = args[1]
if not isinstance(query["where"], dict):
Expand Down Expand Up @@ -336,7 +336,7 @@ def delete_one(*, where: Optional[MyTableWhereFilter]) -> PolyDeleteResult: ...
@staticmethod
def delete_one(*args, **kwargs) -> PolyDeleteResult:
if args:
if len(args) != 2 or or not isinstance(args[0], str) not isinstance(args[1], dict):
if len(args) != 2 or not isinstance(args[0], str) or not isinstance(args[1], dict):
raise TypeError("Expected id and query as arguments or as kwargs")
query = args[1]
if not isinstance(query["where"], dict):
Expand Down
Loading