Fix #20 : Added "unreachable" ErrorType and regex.#43
Open
ckerens wants to merge 1 commit intopoint-source:mainfrom
Open
Fix #20 : Added "unreachable" ErrorType and regex.#43ckerens wants to merge 1 commit intopoint-source:mainfrom
ckerens wants to merge 1 commit intopoint-source:mainfrom
Conversation
point-source
requested changes
Feb 2, 2023
| } | ||
|
|
||
| // Host or Network Unreachable | ||
| if (data.contains(unreachableStr)) { |
Owner
There was a problem hiding this comment.
These if statements should probably become if/else unless we can guarantee that the presence of one truthy contains() negates the others. Reason being that we don't want one line of ping output to result in two separate PingData events.
Contributor
Author
|
I can take care of this sometime in the next few days. Currently deep in another project, but I agree on the requested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented an "unreachable" ErrorType for Linux/Android, Mac, and Windows.