This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Add support in test framework for signal handling#260
Draft
igchor wants to merge 1 commit intopmem:masterfrom
Draft
Add support in test framework for signal handling#260igchor wants to merge 1 commit intopmem:masterfrom
igchor wants to merge 1 commit intopmem:masterfrom
Conversation
Member
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: 8 of 9 files reviewed, 3 unresolved discussions (waiting on @igchor and @lukaszstolarczuk)
CONTRIBUTING.md line 177 at r1 (raw file):
applications do not crash. It is useful for Rapidcheck tests (it makes shrinking possible) and for ctest. To turn this feature on, set env variable PMEMSTREAM_HANDLE_SIGNAL_FOR_DEBUG=1 and add test_register_sighandlers()
perhaps mark a function with ``
CONTRIBUTING.md line 177 at r1 (raw file):
applications do not crash. It is useful for Rapidcheck tests (it makes shrinking possible) and for ctest. To turn this feature on, set env variable PMEMSTREAM_HANDLE_SIGNAL_FOR_DEBUG=1 and add test_register_sighandlers()
this will work only in c++ tests, isn't it...?
tests/common/test_backtrace.h line 2 at r1 (raw file):
// SPDX-License-Identifier: BSD-3-Clause /* Copyright 2015-2021, Intel Corporation */
-2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is