Skip to content

Conversation

@amyangfei
Copy link
Contributor

What problem does this PR solve?

close #2678

What is changed and how it works?

Test PD pd/api/v1/members API returns non-zero clusterID in response before starting TiDB server to avoid TiDB server gets incorrect cluster-id

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Test multiple times with tiup playground v6.1.7 --db 1 --pd 1 --kv 3 --tiflash 0

  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and kaaaaaaang January 24, 2026 13:19
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added contribution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.31%. Comparing base (7d025cb) to head (bd05357).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
components/playground/instance/pd.go 90.91% 2 Missing ⚠️
components/playground/playground.go 77.78% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
+ Coverage   42.30%   42.31%   +0.01%     
==========================================
  Files         424      424              
  Lines       46888    46919      +31     
==========================================
+ Hits        19834    19853      +19     
- Misses      24390    24398       +8     
- Partials     2664     2668       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TiUP playground bootstrap failed because of getTS error

2 participants