-
Notifications
You must be signed in to change notification settings - Fork 412
io: Fix checksum seek at end (#10341) #10354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ti-chi-bot
merged 7 commits into
pingcap:release-8.5
from
ti-chi-bot:cherry-pick-10341-to-release-8.5
Aug 20, 2025
Merged
io: Fix checksum seek at end (#10341) #10354
ti-chi-bot
merged 7 commits into
pingcap:release-8.5
from
ti-chi-bot:cherry-pick-10341-to-release-8.5
Aug 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
12 tasks
JaySon-Huang
approved these changes
Aug 20, 2025
Lloyd-Pottiger
approved these changes
Aug 20, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/cherry-pick-for-release-8.5
This PR is cherry-picked to release-8.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10341
What problem does this PR solve?
Issue Number: close #10340
Problem Summary:
When there are multiple NULL rows of Strings-like column or vector-like column, TiFlash may save some "empty blocks" into the DMFile. And it happen to be the "empty blocks" are stored at the end of the DMFile.
When TiFlash try to read data from disk,
DMFileReader::readFromDiskwill first callFramedChecksumReadBuffer::doSeekand seek to the "empty block" at the file end. The working_buffer will be release because we read to the end of the file. When TiFlash try to seek to the next "empty block",posmove forward the released working_buffer, leading to reading random data and cause random failure.tiflash/dbms/src/Storages/DeltaMerge/File/DMFileReader.cpp
Lines 542 to 555 in 76a4ec4
tiflash/dbms/src/IO/Checksum/ChecksumBuffer.h
Lines 436 to 440 in dce9588
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note