Re-introduce Agent id attribute by Grufoony · Pull Request #398 · physycom/DynamicalSystemFramework

Grufoony · 2026-02-02T14:01:57Z

No description provided.

codecov · 2026-02-02T14:05:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.55%. Comparing base (53d80bc) to head (f68c6b9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          53       53           
  Lines        6063     6064    +1     
  Branches      657      657           
=======================================
+ Hits         5187     5188    +1     
  Misses        865      865           
  Partials       11       11

Flag	Coverage Δ
unittests	`85.55% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

benchmark/Bench_Agent.cpp


 static void BM_Agent_SetSrcNodeId(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp


 static void BM_Agent_SetStreetId(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp


 static void BM_Agent_SetNextStreetId(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp


 static void BM_Agent_SetSpeed(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp


 static void BM_Agent_SetFreeTime(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp


 static void BM_Agent_IncrementDistance(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp


 static void BM_Agent_Reset(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp

 // Getter benchmarks - these are inline so very fast
 static void BM_Agent_Getters(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Agent.cpp


 static void BM_Agent_Itinerary(benchmark::State& state) {
-  dsf::mobility::Agent agent(0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+  dsf::mobility::Agent agent(0, 0, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


Copilot

Pull request overview

This PR re-introduces an explicit Agent id by adding it to dsf::mobility::Agent constructors and updating call sites across mobility tests, dynamics, and benchmarks.

Changes:

Update Agent to store an Id and require it in constructors.
Update RoadDynamics agent-construction helpers to pass an id when creating agents.
Update unit tests and benchmarks to use the new Agent constructor signatures.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`src/dsf/mobility/Agent.hpp`	Adds `m_id` and updates constructor signatures to require an id.
`src/dsf/mobility/Agent.cpp`	Implements updated constructors initializing `m_id`.
`src/dsf/mobility/RoadDynamics.hpp`	Updates templated `addAgent`/`addAgents` constraints and construction path to include agent ids.
`test/mobility/Test_agent.cpp`	Updates agent construction in unit tests to include ids.
`test/mobility/Test_street.cpp`	Updates agent construction in street-related tests to include ids.
`test/mobility/Test_dynamics.cpp`	Updates agent construction in dynamics tests to include ids.
`test/base/Test_node.cpp`	Updates agent construction used in intersection/node tests to include ids.
`benchmark/Bench_Agent.cpp`	Updates benchmark agent construction to include ids.
`benchmark/Bench_Intersection.cpp`	Updates benchmark code (currently contains API mismatches requiring fixes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-02T14:07:46Z

src/dsf/mobility/RoadDynamics.hpp

+  void RoadDynamics<delay_t>::addAgents(std::size_t const nAgents, TArgs&&... args) {
    for (size_t i{0}; i < nAgents; ++i) {
-      addAgent(std::make_unique<Agent>(this->time_step(), std::forward<TArgs>(args)...));
+      addAgent(std::make_unique<Agent>(
+          this->m_nAddedAgents, this->time_step(), std::forward<TArgs>(args)...));
    }


In addAgents, each loop iteration uses this->m_nAddedAgents as the id without incrementing it, so all agents created in the batch will share the same id. Consider reserving a range of ids up-front via fetch_add(nAgents) and using startId + i (or increment per iteration) to guarantee uniqueness.

Copilot · 2026-02-02T14:07:47Z

benchmark/Bench_Intersection.cpp

    auto agent = std::make_unique<dsf::mobility::Agent>(
        spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
-    intersection.addAgent(0.0, std::move(agent));
+    intersection.addAgent(0, 0.0, std::move(agent));
  }


This benchmark no longer matches the Agent and Intersection::addAgent APIs: Agent construction here is missing the new leading id parameter, and Intersection::addAgent takes (double angle, std::unique_ptr<Agent>) (no leading id). Update the agent construction to include an id and call intersection.addAgent(0.0, std::move(agent)).

test/mobility/Test_agent.cpp

src/dsf/mobility/RoadDynamics.hpp

benchmark/Bench_Agent.cpp

  for (auto _ : state) {
    dsf::mobility::Agent agent(
-        spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+        0, spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Intersection.cpp

    intersection.setCapacity(100);
    auto agent = std::make_unique<dsf::mobility::Agent>(
-        spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+        0, spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Intersection.cpp

    intersection.setCapacity(100);
    auto agent = std::make_unique<dsf::mobility::Agent>(
-        spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+        0, spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


benchmark/Bench_Roundabout.cpp

    roundabout.setCapacity(100);
    auto agent = std::make_unique<dsf::mobility::Agent>(
-        spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);
+        0, spawnTime++, std::make_shared<dsf::mobility::Itinerary>(1, 1), 0);


Grufoony requested a review from Copilot February 2, 2026 14:01

Copilot started reviewing on behalf of Grufoony February 2, 2026 14:02 View session

github-advanced-security bot found potential problems Feb 2, 2026

View reviewed changes

Copilot AI reviewed Feb 2, 2026

View reviewed changes

init

f1c6aeb

Grufoony force-pushed the agentid branch from 97426ba to f1c6aeb Compare February 2, 2026 14:10

github-advanced-security bot found potential problems Feb 2, 2026

View reviewed changes

Copilot fix

f68c6b9

Grufoony merged commit b51ef17 into main Feb 3, 2026
44 checks passed

Grufoony deleted the agentid branch February 3, 2026 08:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-introduce Agent id attribute#398

Re-introduce Agent id attribute#398
Grufoony merged 2 commits intomainfrom
agentid

Grufoony commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Copilot AI left a comment

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check notice

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Grufoony commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check notice

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Feb 2, 2026 •

edited

Loading