Add NoDiscard attribute #5041
Open
Add NoDiscard attribute #5041
+216
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
approved these changes
Dec 17, 2025
DanielEScherzer
requested changes
Dec 27, 2025
| } | ||
|
|
||
| ?> | ||
| ]]> |
Member
There was a problem hiding this comment.
presumably you also have to call the function somewhere
| ]]> | ||
| </programlisting> | ||
| </example> | ||
| </section> |
Member
There was a problem hiding this comment.
I suggest also documented somewhere (maybe just an example) for a $_ or similar being assigned so that the warning isn't shown without needing (void), which is only 8.5+, e.g.
Since attributes are designed to be backwards compatible,
#[\NoDiscard]can also be added to functions and methods even when PHP 8.4 or below are supported, it just won't do anything. On PHP 8.5 and above a warning will be emitted if the result is unused. To suppress the warning without using(void), which is not supported before PHP 8.5, consider using a variable like$_.
$_ = some_command();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.