fix: pass MCP_TIMEOUT to SDK callTool requests #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MCP SDK has a hardcoded DEFAULT_REQUEST_TIMEOUT_MSEC of 60 seconds. Without passing the timeout option to client.callTool(), the MCP_TIMEOUT environment variable was being ignored for tool execution, causing long-running tools (like browser automation) to fail with error -32001 (RequestTimeout) after 60 seconds regardless of the configured timeout. This fix passes getTimeoutMs() to the SDK's callTool options, ensuring the user-configured MCP_TIMEOUT is respected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typescript MCP SDK has a hardcoded DEFAULT_REQUEST_TIMEOUT_MSEC of 60 seconds. Without passing the timeout option to client.callTool(), the MCP_TIMEOUT environment variable was being ignored for tool execution, causing long-running tools (like browser automation) to fail with error -32001 (RequestTimeout) after 60 seconds regardless of the configured timeout.
This fix passes getTimeoutMs() to the SDK's callTool options, ensuring the user-configured MCP_TIMEOUT is respected.