Add LGitRemote>>defaultBranchName (WIP)

[tinchodias]

I tested it locally with this code:

| aRepo aRemote |

aRepo := LGitRepository on: '/Users/tinchodias/d/iceberg-shared-repositories/iceberg' asFileReference.
aRepo open.

aRemote := LGitRemote of: aRepo named: 'pharo-vcs'.
aRemote lookup; connectFetch.
aRemote defaultBranchName. "'refs/heads/dev-1.8'"

TODO:

• Add test.
• Answer a LGitBranch instead of only a String.
• Need to disconnect after connectFetch?
• Support libgit < 1.0.0?

[tinchodias]

Tried to implement it after the following chat in #iceberg channel in Discord:

[tinchodias]

• Need to disconnect after connectFetch?

There is an API function to disconnect but there is no requirement about disconnecting (neither in connect or the example).
I guess it's done by the free.

--- update --

Yes, when the remote is freed the connection is closed: https://libgit2.org/libgit2/#v1.0.0/group/remote/git_remote_free

[tinchodias]

• Support libgit < 1.0.0?

No, we shouldn't care of it for next versions of Iceberg.

[tesonep]

@tinchodias is this still relevant?

[tinchodias]

Yes, I'd do a little pass again. But it doesn't harm to have it... it's API provided by libgit2 that wasn't bound yet.

IIRC, after this is available, it would be possible that Metacello uses it to determine what's the branch to load when there is no explicit :commitish...

Anyway, I have no idea of how possible is to have that modification in Metacello. It may break something.

[pdebruic]

Could also use the .project file and have Metacello look for that.

[guillep]

Hi @tinchodias are there news on this front?

[astares]

@tinchodias Any update on this?

[tinchodias]

@tesonep @guillep @astares do we still need to support <v1.0.0 ?
I don't remember now details but evidently I needed to add this version-dependent code... And I suspect we can assume >=v1.0.0.

[tinchodias]

This readStringUTF8 needs update, I think

[tinchodias]

Please check #71