add WideString>>asLGitExternalString and WideSymbol>>asLGitExternalString to create an external bytes in utf-8#102
Open
tomooda wants to merge 1 commit intopharo-vcs:Pharo14from
Open
Conversation
…ring to create an external bytes in utf-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this patch, LibGit2 fails to commit a UTF-8 filenames because String>>asLGitExternalString assumes the receiver is a ByteString. Iceberg does not suffer this issue, but other code that directly uses LibGit2 binding may be affected.
This patch provides WideString>>asLGitExternalString that encodes the receiver into a ByteString with UTF-8 and then create an. external string using String>>asLGitExternalString.