server-generated session_id; client generated crc32 values for chunks; #15
+261
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- require server-generated session_id value. index.html: - removed client generation of session_id value. - client now calculates crc values for chunks.. sends to server for verification.
- log error on chunk crc mismatch.
….ctx.file_name). - optionally, error if file length doesn't match breadcrumb specified from upstream lua processor (ngx.ctx.file_length).
- added move successful uploads if $success_destination_dir variable is set in .conf.
…m lua modules to backend storage handler data.
Owner
|
Thanks for PR with very impressive changes. The scope of them is quite broad so I think splitting them into separate PRs with updated tests would make them easier to evaluate and introduce progressively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.html: