Bump versions to avoid confusion around releases. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo vendor` has issues with the current type_hash dependencies. The git repository for v0.3.0 contains a version of type_hash_core labelled v0.2 but slightly different in repository labels than the v0.2 checked into crates.io. (missing repository, for instance). `cargo vendor` is pulling v0.2 from crates.io rather than using the `path = "../core"` version specified in type_hash which means it is also dropping the repository label on vendored crates but not when the crate is unvendored. I'm unclear on what should be the correct semantics here. This change just bumps all versions to circumvent any issues. It'll require a new release to be pushed to crates.io as well.
`cargo vendor` has issues with the current type_hash dependencies. The git repository for v0.3.0 contains a version of type_hash_core labelled v0.2 but slightly different in repository labels than the v0.2 checked into crates.io. (missing repository, for instance). `cargo vendor` is pulling v0.2 from crates.io rather than using the `path = "../core"` version specified in type_hash which means it is also dropping the repository label on vendored crates but not when the crate is unvendored. I'm unclear on what should be the correct semantics here. This change just bumps all versions to circumvent any issues. It'll require a new release to be pushed to crates.io as well.
github-actions bot
pushed a commit
to gnoliyil/fuchsia
that referenced
this pull request
Nov 3, 2022
This is to help filesystem developers identify changes that inadvertently affect filesystem storage formats. This is forked because a sub-crate (type_hash_core) lacks the repository field in Cargo.toml, leading to license checks failing. If a [pull request](peterjoel/type_hash#3) is accepted by the author, this can be converted to a regular vendored crate. Bug: 112718 Change-Id: I152816e0e4288a25d73f8f4ee23b36935675b329 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/746022 Commit-Queue: Aaron Drew <ripper@google.com> Reviewed-by: Adam Barth <abarth@google.com> Reviewed-by: Joseph Ryan <josephry@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo vendorhas issues with the current type_hash dependencies.The git repository for v0.3.0 contains a version of type_hash_core labelled v0.2 but this is slightly different (e.g. in repository labels) than the v0.2 checked into crates.io.
cargo vendoris pulling v0.2 from crates.io rather than using thepath = "../core"version included in the repo and specified intype_hash/Cargo.tomlwhich means it is also dropping the repository label on vendored crates but not when the crate is unvendored.I'm unclear on the correct semantics here for
cargo vendor. This change just bumps all versions to circumvent any issues. It'll require a new release to be pushed to crates.io as well.