Open
Conversation
|
did you run the tests after removing that "useless" return value? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think testrocket is really interesting idea.
But there is some legacy code snippets.
It seems to be left behind in the flow of improvement.
1. remove useless retun value
def _show(r); (TestRocket.out || STDERR) << r + "\n"; r endThat variable "r" was used when testrocket had been started to invent.
But it`s logic is changed, return value is not used now.
2. remove Proc.send
Proc.send :include, TestRocketnow refine and using works enough.
We don't have to load TestRocket module using send method.