Skip to content

Conversation

@gsexton
Copy link
Contributor

@gsexton gsexton commented Apr 4, 2025

Fixes #105

This PR fixes issues in the Inky 7.3 Impression Driver.

  • Changed the SPI CS pin to work under automatic or manual control. This allows it to work when CS is controlled by SPI, or when it is controlled manually. We don't want it to fail in the configuration the Pimoroni python driver requires.
  • Changed the wait() routine to use a 10ms debounce on WaitForEdge() as the python driver does.
  • Fixed an issue in the image copy where the image byte wasn't copied (see line 530 of impression.go).
  • If the BUSY line is high on entry to wait to go directly to a timed wait as the python driver does.
  • Fixed errors in the palette definitions. Removed extra memory allocation.

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 52.2%. Comparing base (f009056) to head (b0ebc0d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
inky/inky.go 0.0% 41 Missing ⚠️
inky/impression.go 0.0% 33 Missing ⚠️
inky/types.go 0.0% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.0%) is below the target coverage (40.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #106     +/-   ##
=======================================
- Coverage   52.4%   52.2%   -0.2%     
=======================================
  Files        113     113             
  Lines      14226   14276     +50     
=======================================
  Hits        7455    7455             
- Misses      6425    6475     +50     
  Partials     346     346             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gsexton
Copy link
Contributor Author

gsexton commented Apr 5, 2025

Still thinking through this a little. I've got a some more testing to do.

@gsexton
Copy link
Contributor Author

gsexton commented Apr 5, 2025

OK, this is ready now.

@edwinavalos
Copy link

Great timing! I just tried to use the periph inky libraries for the first time yesterday and was running into some of the issues outlined in #105. Big difference in my attempts is that I am trying to control a inky WHAT yellow.

I pulled down this branch and was able to get my display updating correctly now instead of the cmd/inky command exiting with no updates. Thank you for taking the time to fix this, a random stranger thanks you!

@gsexton gsexton merged commit 6b31587 into periph:main Apr 18, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Inky Impression 7.3 Does not Work As Expcted

3 participants