Renaming JSerializFilePicker to JSerializedFilePicker

[manumafe98]

pull request

The goal was to rename the class: JSerializFilePicker to JSerializedFilePicker

Issue which the PR addresses

Fixes #887

Environment in which the PR was developed (OS, IDE, Java version, etc.)

Windows 10, IntrelliJ IDEA2023.3.2, JDK 21

Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)

• I am not sure what tests are needed for this change in particular

[johnbrvc]

@manumafe98 Thanks for making a pull request! However, please note that we have a very specific form that must be filled out whenever a PR is made. It should appear when you attempt to issue the PR using Github. Please view some of the other PR's for the PC2 project to get an idea of how to fill out the form. Again, thanks for your interest in contributing.

[manumafe98]

@johnbrvc I updated the PR with the asked information, if you can give me a hand on how to test this change!

[johnbrvc]

Nominally, you should completely build the project and sub-projects, and run all the junit tests. There are Ant "build.xml" options to do this. For this case, though, I just let the workflow run and it should run all the tests and report the results.

[manumafe98]

Nominally, you should completely build the project and sub-projects, and run all the junit tests. There are Ant "build.xml" options to do this. For this case, though, I just let the workflow run and it should run all the tests and report the results.

Great, thanks for the information!

[johnbrvc]

I propose that we remove the JSerializFilePickerToJSerializedFilePicker [sic] class/module completely from the project since it is not referenced anywhere else, and hasn't been for quite some time.

[manumafe98]

Okey, then i will update the branch to remove it!

[manumafe98]

@johnbrvc Done! I tried building the project before and after the change, in eclipse and intellij, following this procedure but the test are failing, could it be because of my java versions? I currently have installed Java Platform Se 21.0.1 and Java Platform Se 17.0.9

[johnbrvc]

@johnbrvc Done! I tried building the project before and after the change, in eclipse and intellij, following this procedure but the test are failing, could it be because of my java versions? I currently have installed Java Platform Se 21.0.1 and Java Platform Se 17.0.9

Yes. You need a 1.8 JDK to build and run the JUnits.

[manumafe98]

Great! I guess also I should install an older version of Eclipse, do you recommend me someone in particular? Thanks for all your help

[johnbrvc]

Great! I guess also I should install an older version of Eclipse, do you recommend me someone in particular? Thanks for all your help

Some of use Eclipse 2021-12 since it still supports Java 1.8 fully.

[manumafe98]

Hi @johnbrvc again thanks for your help, I've downloaded that eclipse version

$ java -version
java version "1.8.0_202"
Java(TM) SE Runtime Environment (build 1.8.0_202-b08)
Java HotSpot(TM) 64-Bit Server VM (build 25.202-b08, mixed mode)

And when I open the project this happens to me

I have 3 errors related to that exception class, could be that the version of java 8 that I got still is not the required to run the project?

[johnbrvc]

Hi @johnbrvc again thanks for your help, I've downloaded that eclipse version

$ java -version
java version "1.8.0_202"
Java(TM) SE Runtime Environment (build 1.8.0_202-b08)
Java HotSpot(TM) 64-Bit Server VM (build 25.202-b08, mixed mode)

And when I open the project this happens to me

I have 3 errors related to that exception class, could be that the version of java 8 that I got still is not the required to run the project?

Sounds like you are not building in java 8 (1.8) compatibility mode. It's a setting somewhere in java build options.
Your eclipse appears to be building using a newer version of javac.