enhance webpack config for html and css files#32
enhance webpack config for html and css files#32dt665m wants to merge 1 commit intoparitytech:substrate-node-templatefrom dt665m:feature-webpack-enhancement
Conversation
|
It looks like @dt665m hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
|
[clabot:check] |
|
It looks like @dt665m signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
@dt665m sorry for taking a while to get to this. It does not seem this quite satisfies all the requirements of a solution. Specifically it does not update the Could a solution here be:
Then |
|
@shawntabrizi, I didn't get the clue that docs was used for Github Pages, but now the symlink makes a lot more sense. We usually do Github Pages using an explicit gh-pages branch. Sorry for missing this. What do you think about adding an explicit "docs" script in package.json that copies over the necessary files into the current docs folder? The flow would be:
The docs script could also be made to run after every build automatically to guard against forgetting to run the docs command before checking in. I'm happy to fix it with your solution as well but it'll be harder for me to test as I don't have access to the project so I can't really see the github pages changes or modify it to run index.html from root. My opinion is builds should not be checked in and docs/gh-pages should be explicitly updated. Cheers! |
This is a proposed enhancement to #30 to make the template a bit more customizable and platform agnostic. Overview of changes: