Add react-native export to package.json#3953
Merged
HackbrettXXX merged 3 commits intoparallax:masterfrom Feb 4, 2026
Merged
Conversation
Contributor
stefan-schweiger
commented
Feb 4, 2026
- Add react-native export entry pointing to ES module build
- Fixes Add export for react-native #3935
- Add react-native export entry pointing to ES module build - Fixes parallax#3935
Collaborator
|
Not a fan of adding very framework-specific stuff to a generic library like jspdf. IMO, react native should adopt standard behavior and not expect the whole ecosystem to adapt to it. |
Contributor
Author
|
I need to look up the support for it, but what about "default" to esm and only specify that node needs a special version? |
Contributor
Author
|
So seems like that should work. But typescript recommends to use this order: |
Collaborator
|
Adding "default" is probably a good idea. I would keep the "browser" export, though. |
Contributor
Author
|
Take a look now |
HackbrettXXX
requested changes
Feb 4, 2026
Collaborator
HackbrettXXX
left a comment
There was a problem hiding this comment.
I think the trailing comma is illegal.
Contributor
Author
|
Sorry you are right. Fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.