Prepare server for 2P time attack #736
Open
+170
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des and allow specification of gameModeID for game requests, including "any" to leave the choice to the opponent
Endaris
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the server for time attack VS by adding the general capability of accepting challenges for specific game modes, making VS the default so that the client does not need to get updated alongside the server and can follow at its own pace instead.
Following deployment, the client could use the introduced field on the ClientProtocol and offer a submenu when challenging a player to pick the game mode for the challenge.
Tangential todo: Indicate the game mode of a match in lobby data.