fix(local-replica): sanitize invalid windows chars in project folder name#330
Open
astarforbae wants to merge 2 commits intooverleaf-workshop:masterfrom
Open
fix(local-replica): sanitize invalid windows chars in project folder name#330astarforbae wants to merge 2 commits intooverleaf-workshop:masterfrom
astarforbae wants to merge 2 commits intooverleaf-workshop:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #329 where users cannot create local replicas of Overleaf projects with invalid Windows filename characters (like colons) in their titles. The fix adds a sanitization function that replaces invalid characters with underscores, removes trailing dots/spaces, handles empty results, and avoids Windows reserved filenames (like "con", "aux", etc.), but only applies this sanitization on Windows to preserve existing behavior on other platforms.
Changes:
- Added a private static method
sanitizeProjectFolderName()that sanitizes project names for Windows filesystem compatibility - Modified
validateBaseUri()to use the sanitized folder name instead of the raw project name when creating local replica directories - Platform-specific handling ensures sanitization only occurs on Windows (
win32platform)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
style(local-replica): align equality spacing in sanitizer Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
Summary
title
win32) to preserve existing behavior on other platformsValidation
:on Windows