Skip to content

fix: spider chart with variable data points#41

Merged
psterpu-c merged 4 commits intomainfrom
spider-chart
Oct 3, 2025
Merged

fix: spider chart with variable data points#41
psterpu-c merged 4 commits intomainfrom
spider-chart

Conversation

@psterpu-c
Copy link
Contributor

📝 Description

🔗 Related Issue

Closes #(issue number)

🧪 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Style/design update
  • 🔧 Build/CI update
  • ♻️ Refactoring (no functional changes)
  • 🧪 Tests only

🧪 Testing

  • Unit tests pass (yarn test)
  • Storybook builds successfully (yarn storybook)
  • Manual testing completed
  • Cross-browser testing (if applicable)

Test Instructions:

♿ Accessibility

  • Follows WCAG 2.1 AA guidelines
  • Keyboard navigation tested
  • Screen reader tested
  • Color contrast verified
  • Focus indicators present
  • ARIA attributes added where needed

📱 Responsive Design

  • Mobile responsive
  • Tablet responsive
  • Desktop responsive
  • All breakpoints tested

📚 Documentation

  • Storybook story added/updated
  • Component props documented
  • Usage examples provided
  • README updated (if needed)
  • TypeScript types exported

🔄 Breaking Changes

  • This PR introduces breaking changes
  • Migration guide provided (if breaking changes)
  • Version bump required

📋 Checklist

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Code is commented where necessary
  • No console.log statements left in code
  • Build passes locally
  • Tests added for new functionality
  • Existing tests still pass
  • No TypeScript errors
  • No accessibility violations
  • PR title follows conventional commit format

📸 Screenshots

Before

After

🔍 Additional Notes


For Maintainers:

  • Ready for review
  • Requires design review
  • Requires accessibility review
  • Ready to merge

@psterpu-c psterpu-c requested a review from a team as a code owner October 3, 2025 06:39
Signed-off-by: Paul Sterpu <psterpu@cisco.com>
Signed-off-by: Paul Sterpu <psterpu@cisco.com>
@psterpu-c psterpu-c merged commit b57f70f into main Oct 3, 2025
7 checks passed
@psterpu-c psterpu-c deleted the spider-chart branch October 3, 2025 06:48
@rafaelsilva29
Copy link
Member

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants