Skip to content

feat: add findings artifact component#15

Merged
juliarvalenti merged 1 commit intomainfrom
review/findings-clean
Feb 12, 2026
Merged

feat: add findings artifact component#15
juliarvalenti merged 1 commit intomainfrom
review/findings-clean

Conversation

@juliarvalenti
Copy link
Collaborator

Summary

Fixes Applied

  • findings.tsx: Refactored from 5 split UI components (hax/components/findings/) into a single self-contained file following standard artifact pattern
  • types.ts: Added .describe() annotations on all Zod schema fields
  • action.ts: Added Zod validation for findingsJson parsing
  • index.ts: Added missing FINDINGS_DESCRIPTION barrel export
  • Dependencies: Removed @radix-ui/react-popover dependency; replaced popover overflow with inline expand
  • Registry: Simplified entry (no UI component registration needed); dropped duplicate files for already-merged artifacts

Files

hax/artifacts/findings/
├── findings.tsx     # Self-contained panel with cards, source chips, expand overflow
├── types.ts         # Zod schemas with .describe() annotations
├── action.ts        # CopilotKit hook with Zod validation
├── description.ts   # AI prompt guidance
├── index.ts         # Barrel exports
└── README.md        # Documentation

Test plan

  • hax add artifact findings installs correctly
  • Component renders with sample data and source chips
  • Overflow "+N" chip expands to show all sources inline

Refactored from PR #3 to follow standard artifact pattern:
- Inlined UI components into single self-contained findings.tsx
- Removed radix-popover dependency (replaced with inline expand)
- Added Zod validation in action handler
- Added .describe() annotations on all schema fields
- Added FINDINGS_DESCRIPTION barrel export

Signed-off-by: Julia Valenti (julvalen) <julvalen@cisco.com>
@juliarvalenti juliarvalenti merged commit 961d6d9 into main Feb 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant