Implement ICE consent freshness for connectivity detection#44
Implement ICE consent freshness for connectivity detection#44murillo128 wants to merge 1 commit intoossrs:workflowsfrom
Conversation
murillo128
force-pushed
the
consent-freshness
branch
2 times, most recently
from
39b2fc7 to
826b6ac
Compare
|
Hi Sergio, thank you for your PR. Could you please provide some background information for this PR in the description? The patch will be generated based on the title and description, and it will be sent via email to the FFmpeg community. Therefore, a detailed description is important for the maintainers to review this PR. |
libavformat/whip.c
Outdated
| /** | ||
| * Consent-freshness constants ����������������������������������������� | ||
| */ | ||
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms � RFC 7675 default */ |
There was a problem hiding this comment.
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms � RFC 7675 default */ | |
| #define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms - RFC 7675 default */ |
|
WHIP RFC 9725 requires that once a session is set up, consent freshness as per RFC7675 SHALL be used to detect non-graceful disconnection by full ICE implementations and DTLS teardown for session termination by either side. The patch adds some minimal support for consent freshness, sending ICE requests peridiodically and terminating when we don't receive response to those requests for a number of consecutive requests. |
|
I think all special chars are removed now |
winlinvip
force-pushed
the
workflows
branch
3 times, most recently
from
3294e09 to
4aa17ba
Compare
winlinvip
changed the title
ghost
Signed-off-by: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
JackLau1222
force-pushed
the
consent-freshness
branch
from
c0cc525 to
a10ffe5
Compare
JackLau1222
force-pushed
the
workflows
branch
2 times, most recently
from
2c40a5c to
80db6eb
Compare
JackLau1222
force-pushed
the
workflows
branch
from
80db6eb to
3c6b4dc
Compare
JackLau1222
force-pushed
the
workflows
branch
from
3c6b4dc to
4322123
Compare
2 participants
WHIP RFC 9725 requires that once a session is set up, consent freshness as per RFC7675 SHALL be used to detect non-graceful disconnection by full ICE implementations and DTLS teardown for session termination by either side.
The patch adds some minimal support for consent freshness, sending ICE requests peridiodically and terminating when we don't receive response to those requests for a number of consecutive requests.