feat!: add options pattern to OSCAL catalog generation #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
force-pushed
the
cleanup/oscal-logic
branch
from
02c0b2b to
ae74d5d
Compare
jpower432
changed the title
jpower432
force-pushed
the
cleanup/oscal-logic
branch
from
ae74d5d to
9a11829
Compare
This updates the Layer 1 and Layer 2 implementations of OSCAL generation for a more cohesive approach. The API now uses an options pattern instead of positional parameters, providing more flexibility and consistency across OSCAL generation functions. Breaking change: FromCatalog renamed to CatalogFromCatalog and now uses WithControlHref option instead of positional controlHREF parameter. Assisted by: Composer(Cursor AI) Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432
force-pushed
the
cleanup/oscal-logic
branch
from
9a11829 to
dbbc5eb
Compare
This also makes the good-aigf.yaml test OSCAL-compliant Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432
force-pushed
the
cleanup/oscal-logic
branch
from
dbbc5eb to
ff3896f
Compare
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the OSCAL generation logic post-move. The Layer 1 and Layer 2 approaches were somewhat divergent. Now that they are in the same package, we can reuse the functional options approach from Layer 1. Adds OSCAL-CLI validation CI to ensure there are no validation failures.
Schema Changes
Schema Changes Made
schemas/layer-1.cue) changesschemas/layer-2.cue) changesschemas/layer-3.cue) changesschemas/layer-4.cue) changesSchema Change Details
Testing
Related Issues
Closes #142
Reviewer Hints
The code is primarily reorganized, but
CatalogFromCatalogwas also updated and uses theGenerateOptionsnow.