Remove duplicate mapping server relays from Spot robots#1045
Open
peci1 wants to merge 3 commits intoosrf:masterfrom
Open
Remove duplicate mapping server relays from Spot robots#1045peci1 wants to merge 3 commits intoosrf:masterfrom
peci1 wants to merge 3 commits intoosrf:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1044 .
bosdyn_spot model already has the mapping server relays in its vehicle_topics.launch. However, CCN_SPOT and MARBLE_SPOT also include the relays, but they also include the vehicle_topics.launch from bosdyn_spot. This leads to double inclusion of the launch file and the inability to launch the models.
The roslaunch error is:
I just removed the superfluous includes from the downstream models and left a comment there to remind future editors that it is correct that the relays are missing there.