-
Notifications
You must be signed in to change notification settings - Fork 1
Sharing and using the forum #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not limit these to only the forum. Since they are related both to making & to using mods, maybe misc/ could work?
I ignore CONTRIBUTING for now, but tell me if you want to get reminders as soon as there’s something wrong.
|
I like this format that allows for only taking parts of large CSS mods: Would this go in “Community” or Advaced CSS? |
That would go into managing mods, so neither. |
|
Ok. It could be mentioned in sharing but the instructions are in managing. |
|
How should I add images? Should I wait until I set up GH pages? |
As it is usually done in MD (use relative path for them, I think GH will sort it out correctly) |
|
Ok, I guess the relative path would have a ../ |
|
What else would you like to see before merging? |
I need to re-read it, & you need to fix conflicts with |
So modding-vivaldi/community/assets or modding-vivaldi/assets? |
|
modding-vivaldi/assets (for now the whole repo is one ‘project’) |
|
I was wondering what you had done with the text – are you writing a song? That note sometime somewhere about ‘logical places to add newlines in code’ doesn’t apply to plain text. And why the indentation? |
|
No worries, sorry for being impatient, do it whenever you have time. |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ grep -nE '^.{81,}$' asking-questions.md
13: - Share any ways you thought you might fix the problem or things that didn't work
14: - Don't add the "mod" tag to your post - save that for when you actually publish a mod
$ grep -nE '^.{81,}$' sharing.md
30: * Author(s): <Here you can add your forum username, and username for github or any relevant app (also add any other contributors here)>
78:You should also **include a screenshot**. If the mod does something that can only
79:be shown through a screen recording, take a screen recording and upload it as a GIF.(sharing.md:30 is in a code block, so it can be kept as-is wrt line length)
There are also some issues with the chars (dashes/quotes/apostrophe) used, but I think I’ll fix them myself when you’re done.
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
…to tiosgz-master Reduce conflicts
Merge branch 'tiosgz-master' into sharing Reduce conflicts
…nto sharing Git Pull
|
Other than the updated tagging information after the forum admins fix tagging, is this ready to merge? |
|
I don’t know, will have to review it again. I guess I’ll have some tiny fixes at least. Sorry, cannot review today, but hopefully tomorrow I’ll be able to. |
|
So that’s most of it (f66d57c to 5018df0). If you want to revert something – no problem if you give a good reason against mine. Currently I see two problems (once they are solved I may see more 😉)
Hmm… and it might go into |
|
Looks nice, thank you. |
Here we can discuss sharing and using the forum. I put this into a folder called "forum" (should I change the name or purpose?).
I know people have strong opinions about this so I'd like each section I write to be approved by at least one other person.
Read here:
https://github.com/code3z/modding-vivaldi/tree/sharing/forum
Resolves #10