Skip to content

Conversation

@code3z
Copy link
Contributor

@code3z code3z commented May 26, 2021

Here we can discuss sharing and using the forum. I put this into a folder called "forum" (should I change the name or purpose?).

I know people have strong opinions about this so I'd like each section I write to be approved by at least one other person.

Read here:
https://github.com/code3z/modding-vivaldi/tree/sharing/forum

Resolves #10

@code3z code3z marked this pull request as draft May 26, 2021 00:36
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not limit these to only the forum. Since they are related both to making & to using mods, maybe misc/ could work?

I ignore CONTRIBUTING for now, but tell me if you want to get reminders as soon as there’s something wrong.

@ghost ghost added the misc About modding, but not modding itself label May 27, 2021
@code3z
Copy link
Contributor Author

code3z commented May 30, 2021

I like this format that allows for only taking parts of large CSS mods:
https://github.com/GabeVilela/Vivaldi-GX

Would this go in “Community” or Advaced CSS?

@ghost
Copy link

ghost commented May 30, 2021

I like this format that allows for only taking parts of large CSS mods:
https://github.com/GabeVilela/Vivaldi-GX

Would this go in “Community” or Advaced CSS?

That would go into managing mods, so neither.

@code3z
Copy link
Contributor Author

code3z commented May 30, 2021

Ok. It could be mentioned in sharing but the instructions are in managing.

@code3z
Copy link
Contributor Author

code3z commented May 30, 2021

How should I add images? Should I wait until I set up GH pages?

@code3z code3z marked this pull request as ready for review May 30, 2021 17:59
@ghost
Copy link

ghost commented May 30, 2021

How should I add images? Should I wait until I set up GH pages?

As it is usually done in MD (use relative path for them, I think GH will sort it out correctly)

@code3z
Copy link
Contributor Author

code3z commented May 30, 2021

Ok, I guess the relative path would have a ../

@code3z
Copy link
Contributor Author

code3z commented May 31, 2021

What else would you like to see before merging?

@ghost
Copy link

ghost commented May 31, 2021

What else would you like to see before merging?

I need to re-read it, & you need to fix conflicts with CONTRIBUTING.md

@code3z
Copy link
Contributor Author

code3z commented Jun 1, 2021

Images and other resources like them are in an assets/ directory in the root of the corresponding “project,” structured according to their use.

So modding-vivaldi/community/assets or modding-vivaldi/assets?

@ghost
Copy link

ghost commented Jun 2, 2021

modding-vivaldi/assets (for now the whole repo is one ‘project’)

@ghost
Copy link

ghost commented Jun 2, 2021

I was wondering what you had done with the text – are you writing a song? That note sometime somewhere about ‘logical places to add newlines in code’ doesn’t apply to plain text. And why the indentation?

@code3z
Copy link
Contributor Author

code3z commented Jun 4, 2021

No worries, sorry for being impatient, do it whenever you have time.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ grep -nE '^.{81,}$' asking-questions.md
13: - Share any ways you thought you might fix the problem or things that didn't work
14: - Don't add the "mod" tag to your post - save that for when you actually publish a mod
$ grep -nE '^.{81,}$' sharing.md
30: * Author(s):          <Here you can add your forum username, and username for github or any relevant app (also add any other contributors here)>
78:You should also **include a screenshot**. If the mod does something that can only
79:be shown through a screen recording, take a screen recording and upload it as a GIF.

(sharing.md:30 is in a code block, so it can be kept as-is wrt line length)

There are also some issues with the chars (dashes/quotes/apostrophe) used, but I think I’ll fix them myself when you’re done.

code3z and others added 18 commits June 5, 2021 11:20
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Co-authored-by: tiosgz <53824308+tiosgz@users.noreply.github.com>
Merge branch 'tiosgz-master' into sharing

Reduce conflicts
@code3z
Copy link
Contributor Author

code3z commented Jun 8, 2021

Other than the updated tagging information after the forum admins fix tagging, is this ready to merge?

@ghost
Copy link

ghost commented Jun 9, 2021

I don’t know, will have to review it again. I guess I’ll have some tiny fixes at least. Sorry, cannot review today, but hopefully tomorrow I’ll be able to.

@ghost
Copy link

ghost commented Jun 10, 2021

So that’s most of it (f66d57c to 5018df0). If you want to revert something – no problem if you give a good reason against mine.

Currently I see two problems (once they are solved I may see more 😉)

  • as you’ve already said, tagging is completely disabled now
  • it is disorganised:
    • I’d move the posting as a question part above asking for mods
    • sharing mods – you write about:
      • forum (& alternate way)
      • why share & inconveniences
      • alternative way
      • ‘best practices’ wrt. what a published piece of code should include
      • forum
        • tagging
        • writing
        • editing
      • ‘better just link to it’
    • I’d imagine an order more like this:
      • why share & inconveniences
      • ‘best practices’ wrt. what a published piece of code should include
      • ways
      • (you can omit git completely, or just refer to managing mods in the previous point; depends on whether and how you rewrite it)
      • forum
        • writing
          • the text
          • include code, or link to elsewhere?
          • screenshots
          • tags
        • updating (editing)

Hmm… and it might go into basics/, since it is a ‘basic modding skill’ in some way.

@code3z
Copy link
Contributor Author

code3z commented Jun 10, 2021

Looks nice, thank you.
It sounds like tagging will be re-enabled, assuming that isn't too far into the future I will wait until that happens to merge the final draft.
I will look into the organization soon.

@ghost ghost deleted a comment from code3z Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

misc About modding, but not modding itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing Mods (4)

2 participants