Skip to content

Comments

Handle single vs multiple sensors in generators.#96

Open
atti92 wants to merge 6 commits intomainfrom
fb-84
Open

Handle single vs multiple sensors in generators.#96
atti92 wants to merge 6 commits intomainfrom
fb-84

Conversation

@atti92
Copy link
Contributor

@atti92 atti92 commented Feb 11, 2026

Implement #84

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes “single” vs “multiple” sensor mode handling across simulated air-traffic generators/clients, and updates settings/tests to rely on shared constants.

Changes:

  • Introduce SENSOR_MODE_SINGLE / SENSOR_MODE_MULTIPLE constants and constrain settings with Literal["single","multiple"].
  • Add a use_multiple_sensors flag to simulators/clients and randomly assign sensor_id when configured for multiple sensors.
  • Update settings tests to assert against the shared constants instead of raw string literals.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_client_settings.py Uses SENSOR_MODE_SINGLE/MULTIPLE constants in assertions.
src/openutm_verification/simulator/geo_json_telemetry.py Adds use_multiple_sensors and random sensor assignment in GeoJSON generator.
src/openutm_verification/core/clients/air_traffic/blue_sky_client.py Random sensor assignment when configured for multiple sensors.
src/openutm_verification/core/clients/air_traffic/bayesian_air_traffic_client.py Random sensor assignment; returns [] instead of None on early exits.
src/openutm_verification/core/clients/air_traffic/base_client.py Defines sensor-mode constants; tightens settings typing with Literal.
src/openutm_verification/core/clients/air_traffic/air_traffic_client.py Computes/passes use_multiple_sensors into GeoJSON simulator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@atti92 atti92 self-assigned this Feb 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

atti92 and others added 4 commits February 13, 2026 20:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant