Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes “single” vs “multiple” sensor mode handling across simulated air-traffic generators/clients, and updates settings/tests to rely on shared constants.
Changes:
- Introduce
SENSOR_MODE_SINGLE/SENSOR_MODE_MULTIPLEconstants and constrain settings withLiteral["single","multiple"]. - Add a
use_multiple_sensorsflag to simulators/clients and randomly assignsensor_idwhen configured for multiple sensors. - Update settings tests to assert against the shared constants instead of raw string literals.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_client_settings.py | Uses SENSOR_MODE_SINGLE/MULTIPLE constants in assertions. |
| src/openutm_verification/simulator/geo_json_telemetry.py | Adds use_multiple_sensors and random sensor assignment in GeoJSON generator. |
| src/openutm_verification/core/clients/air_traffic/blue_sky_client.py | Random sensor assignment when configured for multiple sensors. |
| src/openutm_verification/core/clients/air_traffic/bayesian_air_traffic_client.py | Random sensor assignment; returns [] instead of None on early exits. |
| src/openutm_verification/core/clients/air_traffic/base_client.py | Defines sensor-mode constants; tightens settings typing with Literal. |
| src/openutm_verification/core/clients/air_traffic/air_traffic_client.py | Computes/passes use_multiple_sensors into GeoJSON simulator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/openutm_verification/core/clients/air_traffic/blue_sky_client.py
Outdated
Show resolved
Hide resolved
src/openutm_verification/core/clients/air_traffic/blue_sky_client.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #84