fix: promote cmd should sync app-interface first before making change#837
fix: promote cmd should sync app-interface first before making change#837feichashao wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: feichashao The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@feichashao: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Code changes assisted by Claude Code. Reviewed and validated by human.
Problem
When I use the promote saas command, it failed to create a commit.
The issue was,
osdctlreads the current git hash in the current branch.osdctltries to replace the currently hash in themasterbranch with the new hash. However, themasterbranch is out of sync with the upstream branch.masterbranch is not tracking theorigin/master.Changes
origin/masterbefore reading and replacing the git hash.