Skip to content

OCPBUGS-59907: Improve egressIP skip "Test not applicable for proxy setup" #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiguelCarpio wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

OCPBUGS-59907: Improve egressIP skip "Test not applicable for proxy setup" #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extended/openstack/egressip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ var _ = g.Describe("[sig-installer][Suite:openshift/openstack][egressip] An egre
// TODO revert once https://issues.redhat.com/browse/OSASINFRA-3079 is resolved
proxy, err := oc.AdminConfigClient().ConfigV1().Proxies().Get(ctx, "cluster", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
if proxy.Status.HTTPProxy != "" {
if os.Getenv("HTTP_PROXY") != "" || os.Getenv("HTTPS_PROXY") != "" || proxy.Status.HTTPProxy != "" {
Copy link
Member

@mandre mandre Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what the difference is between checking for the HTTP(S)_PROXY environment variable and proxy.Status.HTTPProxy ?

If we need to add more conditions to know if the test runs behind a proxy, perhaps it's time to introduce a function for it and make it consistent across all the tests?

e2eskipper.Skipf("Test not applicable for proxy setup")
}

Expand Down