Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #5480

/assign yuqi-zhang

- Added `hostIP: 127.0.0.1` to the containerPort 8798 to explicitly indicate
  that the health port is only bound to localhost.
- Matches the existing behavior in logs:
    "Starting health listener on 127.0.0.1:8798"
  and address config: Addr: "127.0.0.1:8798"
- This is informational and clarifies that this port is not externally exposed.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-65545 has been cloned as Jira Issue OCPBUGS-67264. Will retitle bug to link to clone.

Jira Issue OCPBUGS-67007 has been cloned as Jira Issue OCPBUGS-67265. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-67264, OCPBUGS-67265: cherry pick to few fixes that needed for missing services and configuration

Details

In response to this:

This is an automated cherry-pick of #5480

/assign yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-65545, OCPBUGS-67007: cherry pick to few fixes that needed for missing services and configuration [release-4.19] OCPBUGS-67264, OCPBUGS-67265: cherry pick to few fixes that needed for missing services and configuration Dec 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-67264, which is invalid:

  • expected dependent Jira Issue OCPBUGS-65545 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-67265, which is invalid:

  • expected dependent Jira Issue OCPBUGS-67007 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5480

/assign yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuqi-zhang yuqi-zhang changed the title [release-4.19] OCPBUGS-67264, OCPBUGS-67265: cherry pick to few fixes that needed for missing services and configuration [release-4.19] OCPBUGS-67264: cherry pick to few fixes that needed for missing services and configuration Dec 12, 2025
@yuqi-zhang
Copy link
Contributor

/jira refresh

removed one of the bugs to make it easier to backport

@openshift-ci-robot
Copy link
Contributor

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-67264, which is invalid:

  • expected dependent Jira Issue OCPBUGS-65545 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

removed one of the bugs to make it easier to backport

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuqi-zhang
Copy link
Contributor

/jira refresh
/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 17, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-67264, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-65545 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-65545 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh
/approve
/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr December 17, 2025 00:13
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@yuqi-zhang
Copy link
Contributor

/cherry-pick release-4.18
/verified later @aabughosh

I think we can get this in given the previous versions have been validated, and we can continue the process that way.

@openshift-cherrypick-robot
Copy link
Author

@yuqi-zhang: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.18
/verified later @aabughosh

I think we can get this in given the previous versions have been validated, and we can continue the process that way.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

@yuqi-zhang: This PR has been marked to be verified later by @aabughosh.

Details

In response to this:

/cherry-pick release-4.18
/verified later @aabughosh

I think we can get this in given the previous versions have been validated, and we can continue the process that way.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1953be0 and 2 for PR HEAD 507dbb2 in total

@yuqi-zhang
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7681914 into openshift:release-4.19 Dec 19, 2025
14 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-67264: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-67264 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #5480

/assign yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@yuqi-zhang: #5490 failed to apply on top of branch "release-4.18":

Applying: Add hostIP 127.0.0.1 to machine-config-daemon port 8798
Applying: add a relevant svc to the crio port
Using index info to reconstruct a base tree...
A	templates/arbiter/01-arbiter-kubelet/_base/files/criometricsproxy.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): templates/arbiter/01-arbiter-kubelet/_base/files/criometricsproxy.yaml deleted in HEAD and modified in add a relevant svc to the crio port. Version add a relevant svc to the crio port of templates/arbiter/01-arbiter-kubelet/_base/files/criometricsproxy.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 add a relevant svc to the crio port

Details

In response to this:

/cherry-pick release-4.18
/verified later @aabughosh

I think we can get this in given the previous versions have been validated, and we can continue the process that way.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.