Skip to content

Conversation

@jgbernalp
Copy link
Contributor

No description provided.

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp requested review from anpingli and zhuje December 18, 2025 12:37
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2025

@jgbernalp: This pull request references OU-1144 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2025
@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgbernalp
Copy link
Contributor Author

/retest

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

New changes are detected. LGTM label has been removed.

@etmurasaki
Copy link
Contributor

/label qe-approved
comments in jira.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 22, 2025

@jgbernalp: This pull request references OU-1144 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anpingli
Copy link

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2025
@anpingli
Copy link

anpingli commented Dec 23, 2025

@jgbernalp I can’t see pods whose logs are not being sent out. Is that correct? Do we want to display all pods no matter logs are sent to loki or not ?

@jgbernalp
Copy link
Contributor Author

@anpingli yes. This will be an indicator that something is wrong with the collector or the application producing logs not reaching loki. We merge the k8s api results with loki labels results, to show resources without logs or deleted resources logs.

@anpingli
Copy link

anpingli commented Jan 5, 2026

@jgbernalp the bold lines below are not as expected.

when log in as kubeadmin,

the namespaces can be displayed base on tenant. that is correct
the pods/containers can not be displayed base on tenant. that is wrong.
there are new pods (Logs weren't sent into lokistack) in AdminConsole ->Observe->logs. That is correct.
there is not new pod(Logs weren't sent into lokistack) in DevConsole->Observe->logs. That is wrong.
there is not new pod(Logs weren't sent into lokistack) in AdminConsole ->pod->Agg Logs. That should be correct.
there is not new pod(Logs weren't sent into lokistack) in DevConsole-> pod->Agg Logs. That should be correct.

when log in as non-cluster-admin users with role below

oc adm policy add-cluster-role-to-user view ${user_name}
oc adm policy add-cluster-role-to-user cluster-logging-application-view ${user_name}
oc adm policy add-cluster-role-to-user cluster-logging-audit-view ${user_name}
oc adm policy add-cluster-role-to-user cluster-logging-infrastructure-view ${user_name}
oc adm policy add-cluster-role-to-user monitoring-rules-edit ${user_name}
oc adm policy add-cluster-role-to-user cluster-monitoring-view ${user_name}

the namespaces can be displayed base on tenant. that is correct.
the pods/containers can be displayed base on tenant. that is correct.
there are new pods (Logs weren't sent into lokistack) in AdminConsole ->Observe->logs. That is correct.
there is not new pod(Logs weren't sent into lokistack) in DevConsole->Observe->logs. That is wrong.
there is not new pod(Logs weren't sent into lokistack) in AdminConsole ->pod->Agg Logs. That should be correct.
there is not new pod(Logs weren't sent into lokistack) in DevConsole-> pod->Agg Logs. That should be correct.

Step to test:

  1. Send pods logs in namespace1 to lokistack
  2. Delete the pod in namespace1
  3. remove CLF
  4. create new pods in namespace1
  5. create new namespace2 and pods in this namespace

Expected Result:
The namespaces, pods, containers can be displayed base on tenant.
All pods ( deleted, running and pods whose logs are not in lokistack) can be displayed in Attribute-options in observe-> Log

Actual Result:
we can not see new pods in AttributeOptions in some cases.

@anpingli
Copy link

anpingli commented Jan 5, 2026

/canel qe-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants