Skip to content

WIP: Rebase 1.35 #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jacobsee wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Rebase 1.35 #2055

jacobsee wants to merge 4 commits into from

Conversation

@jacobsee
Copy link
Member

@jacobsee jacobsee commented Nov 19, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
@openshift-ci openshift-ci bot requested review from bertinatto and deads2k November 19, 2025 22:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacobsee
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacobsee jacobsee force-pushed the rebase-1.35 branch 3 times, most recently from abe97a4 to b5b32f8 Compare December 4, 2025 20:22
@jacobsee
Copy link
Member Author

jacobsee commented Dec 12, 2025

/retest

@jacobsee
bump(k8s): update k8s.io/* dependencies to v1.35
2137cbd
@jacobsee
bump(k8s): go mod vendor
2a14bf6
@jacobsee
manifestclient: support WatchList sendInitialEvents
17ab3b3 
The WatchListClient feature gate was enabled by default in k8s 1.35, causing informers to use sendInitialEvents=true in watch requests. This requires the watch stream to send ADDED events for existing objects followed by a BOOKMARK event to signal sync. Otherwise, TestBasicInformer tests fail.
@jacobsee
TEMPORARY: Use custom builder image with golang-1.25
3cc6dcc
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@jacobsee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 3cc6dcc link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@deads2k deads2k Awaiting requested review from deads2k

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jacobsee