Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #256

/assign damdo

…olicy: Ignore

Add functions to set the failurePolicy to Ignore for both mutating and validating webhooks handling IPAM resources.

During bootstrap, the bootstrap node's Kube API Server receives IPAM create requests but is unable
to reach the webhooks in the Cluster API namespace.

This is because the bootstrap node doesn't have a route to the pods as it doesn't have access to the pod networks.
If failurePolicy is set to Fail, the KAS cannot reach the webhook endpoints and the request fails, preventing creation of IPAddress and IPAddressClaim resources.

This causes a chicken-and-egg problem as it prevents IPAM provisioning
for the workers which won't start without their IP addresses being allocated.

Setting failurePolicy to Ignore allows the resources to be created even when the webhooks are
unreachable during bootstrap, matching what Machine API also does.

More context: https://redhat-internal.slack.com/archives/C0A2M43S199/p1765540108488539
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-69434 has been cloned as Jira Issue OCPBUGS-69685. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-69685: openshift: CAPI IPAM TechPreviewNoUpgrade: set webhooks failurepolicy: Ignore

Details

In response to this:

This is an automated cherry-pick of #256

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.21] OCPBUGS-69434: openshift: CAPI IPAM TechPreviewNoUpgrade: set webhooks failurepolicy: Ignore [release-4.21] OCPBUGS-69685: openshift: CAPI IPAM TechPreviewNoUpgrade: set webhooks failurepolicy: Ignore Dec 17, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 17, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-69685, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-69434 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-69434 to target a version in 4.22.0, but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #256

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from damdo and racheljpg December 17, 2025 17:52
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@damdo
Copy link
Member

damdo commented Dec 17, 2025

/retest

1 similar comment
@damdo
Copy link
Member

damdo commented Dec 17, 2025

/retest

@damdo
Copy link
Member

damdo commented Dec 17, 2025

/test e2e-aws-serial-1of2

1 similar comment
@damdo
Copy link
Member

damdo commented Dec 18, 2025

/test e2e-aws-serial-1of2

@damdo
Copy link
Member

damdo commented Dec 18, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 18, 2025
@damdo
Copy link
Member

damdo commented Dec 18, 2025

/hold

Waiting for openshift/installer#10169 to merge and a backport to release-4.21 be created.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

@damdo: This PR was included in a payload test run from openshift/installer#10174
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bfbf99e0-dc1e-11f0-9bb7-765439ef7b4f-0

@sunzhaohua2
Copy link

/verified by @sunzhaohua2
launch 4.21,https://github.com/openshift/cluster-api/pull/257,https://github.com/openshift/installer/pull/10174 vsphere,techpreview,static

$ oc get machines.m -n openshift-machine-api             
NAME                                 PHASE     TYPE   REGION   ZONE   AGE
ci-ln-mnpik92-c1627-fcphs-master-0   Running                          39m
ci-ln-mnpik92-c1627-fcphs-master-1   Running                          39m
ci-ln-mnpik92-c1627-fcphs-master-2   Running                          39m
ci-ln-mnpik92-c1627-fcphs-worker-0   Running                          39m
ci-ln-mnpik92-c1627-fcphs-worker-1   Running                          39m
ci-ln-mnpik92-c1627-fcphs-worker-2   Running                          39m
$ oc get node                                                                                                                                        
NAME                                 STATUS   ROLES                  AGE   VERSION
ci-ln-mnpik92-c1627-fcphs-master-0   Ready    control-plane,master   39m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-master-1   Ready    control-plane,master   39m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-master-2   Ready    control-plane,master   39m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-worker-0   Ready    worker                 22m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-worker-1   Ready    worker                 22m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-worker-2   Ready    worker                 22m   v1.34.2
$ oc -n openshift-cluster-api get ipaddresses.ipam.cluster.x-k8s.io -A        
NAMESPACE               NAME                                           ADDRESS        POOL NAME   POOL KIND   AGE
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-0-claim-0-0   10.38.252.5    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-1-claim-0-0   10.38.252.6    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-2-claim-0-0   10.38.252.7    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-0-claim-0-0   10.38.252.8    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-1-claim-0-0   10.38.252.9    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-2-claim-0-0   10.38.252.10   default-0   IPPool      34m
zhsun:aws1/ $ oc -n openshift-cluster-api get ipaddressclaims.ipam.cluster.x-k8s.io -A  
NAMESPACE               NAME                                           POOL NAME   POOL KIND   AGE
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-0-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-1-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-2-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-0-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-1-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-2-claim-0-0   default-0   IPPool      34m

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 19, 2025
@openshift-ci-robot
Copy link

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

Details

In response to this:

/verified by @sunzhaohua2
launch 4.21,https://github.com/openshift/cluster-api/pull/257,https://github.com/openshift/installer/pull/10174 vsphere,techpreview,static

$ oc get machines.m -n openshift-machine-api             
NAME                                 PHASE     TYPE   REGION   ZONE   AGE
ci-ln-mnpik92-c1627-fcphs-master-0   Running                          39m
ci-ln-mnpik92-c1627-fcphs-master-1   Running                          39m
ci-ln-mnpik92-c1627-fcphs-master-2   Running                          39m
ci-ln-mnpik92-c1627-fcphs-worker-0   Running                          39m
ci-ln-mnpik92-c1627-fcphs-worker-1   Running                          39m
ci-ln-mnpik92-c1627-fcphs-worker-2   Running                          39m
$ oc get node                                                                                                                                        
NAME                                 STATUS   ROLES                  AGE   VERSION
ci-ln-mnpik92-c1627-fcphs-master-0   Ready    control-plane,master   39m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-master-1   Ready    control-plane,master   39m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-master-2   Ready    control-plane,master   39m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-worker-0   Ready    worker                 22m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-worker-1   Ready    worker                 22m   v1.34.2
ci-ln-mnpik92-c1627-fcphs-worker-2   Ready    worker                 22m   v1.34.2
$ oc -n openshift-cluster-api get ipaddresses.ipam.cluster.x-k8s.io -A        
NAMESPACE               NAME                                           ADDRESS        POOL NAME   POOL KIND   AGE
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-0-claim-0-0   10.38.252.5    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-1-claim-0-0   10.38.252.6    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-2-claim-0-0   10.38.252.7    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-0-claim-0-0   10.38.252.8    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-1-claim-0-0   10.38.252.9    default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-2-claim-0-0   10.38.252.10   default-0   IPPool      34m
zhsun:aws1/ $ oc -n openshift-cluster-api get ipaddressclaims.ipam.cluster.x-k8s.io -A  
NAMESPACE               NAME                                           POOL NAME   POOL KIND   AGE
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-0-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-1-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-master-2-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-0-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-1-claim-0-0   default-0   IPPool      34m
openshift-machine-api   ci-ln-mnpik92-c1627-fcphs-worker-2-claim-0-0   default-0   IPPool      34m

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sunzhaohua2
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 19, 2025
@openshift-ci-robot
Copy link

@sunzhaohua2: This pull request references Jira Issue OCPBUGS-69685, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-69434 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-69434 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 December 19, 2025 10:09
@damdo
Copy link
Member

damdo commented Dec 20, 2025

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images aa0b86b link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants