Skip to content

OCPBUGS-69434: openshift: CAPI IPAM TechPreviewNoUpgrade: set webhooks failurepolicy: Ignore #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Dec 17, 2025
Merged

OCPBUGS-69434: openshift: CAPI IPAM TechPreviewNoUpgrade: set webhooks failurepolicy: Ignore #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f60caa
UPSTREAM: <carry>: openshift: set Core CAPI IPAM webhooks to failureP…
damdo Dec 15, 2025
88848b0
UPSTREAM: <drop>: Generate OpenShift manifests
damdo Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 46 additions & 46 deletions openshift/infrastructure-components-openshift.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24393,6 +24393,52 @@ metadata:
clusterctl.cluster.x-k8s.io: ""
name: capi-validating-webhook-configuration
webhooks:
- admissionReviewVersions:
- v1
- v1beta1
clientConfig:
service:
name: capi-webhook-service
namespace: openshift-cluster-api
path: /validate-ipam-cluster-x-k8s-io-v1beta2-ipaddress
failurePolicy: Ignore
matchPolicy: Equivalent
name: validation.ipaddress.ipam.cluster.x-k8s.io
rules:
- apiGroups:
- ipam.cluster.x-k8s.io
apiVersions:
- v1beta2
operations:
- CREATE
- UPDATE
- DELETE
resources:
- ipaddresses
sideEffects: None
- admissionReviewVersions:
- v1
- v1beta1
clientConfig:
service:
name: capi-webhook-service
namespace: openshift-cluster-api
path: /validate-ipam-cluster-x-k8s-io-v1beta2-ipaddressclaim
failurePolicy: Ignore
matchPolicy: Equivalent
name: validation.ipaddressclaim.ipam.cluster.x-k8s.io
rules:
- apiGroups:
- ipam.cluster.x-k8s.io
apiVersions:
- v1beta2
operations:
- CREATE
- UPDATE
- DELETE
resources:
- ipaddressclaims
sideEffects: None
- admissionReviewVersions:
- v1
- v1beta1
Expand Down Expand Up @@ -24637,52 +24683,6 @@ webhooks:
resources:
- machinepools
sideEffects: None
- admissionReviewVersions:
- v1
- v1beta1
clientConfig:
service:
name: capi-webhook-service
namespace: openshift-cluster-api
path: /validate-ipam-cluster-x-k8s-io-v1beta2-ipaddress
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.ipaddress.ipam.cluster.x-k8s.io
rules:
- apiGroups:
- ipam.cluster.x-k8s.io
apiVersions:
- v1beta2
operations:
- CREATE
- UPDATE
- DELETE
resources:
- ipaddresses
sideEffects: None
- admissionReviewVersions:
- v1
- v1beta1
clientConfig:
service:
name: capi-webhook-service
namespace: openshift-cluster-api
path: /validate-ipam-cluster-x-k8s-io-v1beta2-ipaddressclaim
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.ipaddressclaim.ipam.cluster.x-k8s.io
rules:
- apiGroups:
- ipam.cluster.x-k8s.io
apiVersions:
- v1beta2
operations:
- CREATE
- UPDATE
- DELETE
resources:
- ipaddressclaims
sideEffects: None
---
apiVersion: v1
kind: Service
Expand Down
6 changes: 3 additions & 3 deletions openshift/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ kind: Kustomization
resources:
- ../config/default

patchesStrategicMerge:
- ./patches/enable-metadata-syncing.yaml

patches:
- path: ./patches/enable-metadata-syncing.yaml
- path: ./patches/failure-policy-ignore-ipam-webhooks.yaml
2 changes: 1 addition & 1 deletion openshift/manifests/0000_30_cluster-api_04_cm.core-cluster-api.yaml
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 24 additions & 0 deletions openshift/patches/failure-policy-ignore-ipam-webhooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Set the failurePolicy to Ignore for the validating webhooks handling IPAM resources.
#
# During bootstrap, the bootstrap node's Kube API Server receives IPAM create requests but is unable
# to reach the webhooks in the Cluster API namespace.
#
# This is because the bootstrap node doesn't have a route to the pods as it doesn't have access to the pod networks.
# If failurePolicy is set to Fail, the KAS cannot reach the webhook endpoints and the request fails, preventing creation of IPAddress and IPAddressClaim resources.
#
# This causes a chicken-and-egg problem as it prevents IPAM provisioning
# for the workers which won't start without their IP addresses being allocated.
Copy link

@mdbooth mdbooth Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically s/start/be created/, but not worth updating unless this needs a respin anyway.

#
# Setting failurePolicy to Ignore allows the resources to be created even when the webhooks are
# unreachable during bootstrap, matching what Machine API also does.
#
# More context: https://redhat-internal.slack.com/archives/C0A2M43S199/p1765540108488539
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: capi-validating-webhook-configuration
webhooks:
- name: validation.ipaddress.ipam.cluster.x-k8s.io
failurePolicy: Ignore
- name: validation.ipaddressclaim.ipam.cluster.x-k8s.io
failurePolicy: Ignore