Skip to content

Conversation

@karanjitsingh01
Copy link
Contributor

@karanjitsingh01 karanjitsingh01 commented Feb 5, 2026

Closing this - #377

and creating new PR

This PR adds an end-to-end test to validate that when a CertificateRequest contains the label certificaterequests.certman.managed.openshift.io, the following workflow is performed successfully:

Revoke the certificate associated with the CertificateRequest.

Delete the CertificateRequest after removing its finalizers.

Verify reconciliation creates a new CertificateRequest .

Ensure the total number of issued certificates remains unchanged before and after the process.

To run the test case, you need to export the below environment variable:
DISABLE_JUNIT_REPORT=false

To run the test:
go test -tags=osde2e ./test/e2e -v

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karanjitsingh01
Once this PR has been reviewed and has the lgtm label, please assign theautoroboto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.15%. Comparing base (59f10dc) to head (608d7dd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files          29       29           
  Lines        2138     2138           
=======================================
  Hits         1222     1222           
  Misses        802      802           
  Partials      114      114           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karanjitsingh01 karanjitsingh01 marked this pull request as draft February 5, 2026 09:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2026
@karanjitsingh01 karanjitsingh01 marked this pull request as ready for review February 5, 2026 09:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2026
@openshift-ci openshift-ci bot requested a review from devppratik February 5, 2026 09:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

@karanjitsingh01: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@karanjitsingh01 karanjitsingh01 changed the title Srep 1220 delete cr SREP-1220: Delete CR and ensure it recreates Feb 6, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2026

@karanjitsingh01: This pull request references SREP-1220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Closing this - #377

and creating new PR

This PR adds an end-to-end test to validate that when a CertificateRequest contains the label certificaterequests.certman.managed.openshift.io, the following workflow is performed successfully:

Revoke the certificate associated with the CertificateRequest.

Delete the CertificateRequest after removing its finalizers.

Verify reconciliation creates a new CertificateRequest .

Ensure the total number of issued certificates remains unchanged before and after the process.

To run the test case, you need to export the below environment variable:
DISABLE_JUNIT_REPORT=false

To run the test:
go test -tags=osde2e ./test/e2e -v

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants