HYPERFLEET-655: fix RabbitMQ deployment bugs and cleanup

[rafabene]

Summary

• Fix values-rabbitmq.yaml: add missing broker.type: rabbitmq for sentinel (without this, sentinel defaults to googlepubsub and fails to start)
• Add default empty adapters.cluster and adapters.nodepool in base values (required by hyperfleet-api chart, prevents lint/deploy errors)
• Remove deprecated root Chart.yaml (never released, replaced by base+overlay pattern)
• Remove migration section from README referencing removed Chart.yaml

Found during

v0.1.0 release validation on GKE cluster.

Test plan

• make lint passes
• Deploy with values-rabbitmq.yaml and confirm sentinel starts with RabbitMQ broker
• Deploy with Pub/Sub and confirm all pods Running

Summary by CodeRabbit

• Chores

  • Removed deprecated root Helm chart configuration, including all metadata and dependency declarations.
  • Removed legacy chart migration guidance from documentation.

• New Features

  • Extended configuration capabilities with new adapter parameters for cluster and nodepool components.
  • Added explicit RabbitMQ broker type configuration option.

[openshift-ci-robot]

@rafabene: This pull request references HYPERFLEET-655 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Fix values-rabbitmq.yaml: add missing broker.type: rabbitmq for sentinel (without this, sentinel defaults to googlepubsub and fails to start)
• Add default empty adapters.cluster and adapters.nodepool in base values (required by hyperfleet-api chart, prevents lint/deploy errors)
• Remove deprecated root Chart.yaml (never released, replaced by base+overlay pattern)
• Remove migration section from README referencing removed Chart.yaml

Found during

v0.1.0 release validation on GKE cluster.

Test plan

• make lint passes
• Deploy with values-rabbitmq.yaml and confirm sentinel starts with RabbitMQ broker
• Deploy with Pub/Sub and confirm all pods Running

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mischulee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

The changes remove the deprecated root Helm Chart.yaml file entirely and its sub-chart dependencies, eliminate the "Migration from Legacy Chart" documentation section from the README, and add new configurable adapter blocks (cluster and nodepool) to the hyperfleet-base values. Additionally, the RabbitMQ broker type is explicitly declared in the hyperfleet-gcp values configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• HYPERFLEET-505 - feat:update the hyperfleetApi for sentinel #6: Modifies the Sentinel broker type configuration structure by setting broker.type: googlepubsub, directly related to the new broker.type: rabbitmq addition in this PR.
• HYPERFLEET-313: Restructure chart with base + overlay pattern for multi-cloud #1: Introduces the base chart values and structure that this PR extends by adding adapters configuration and updating broker type declarations.

Suggested labels

lgtm, approved

Suggested reviewers

• xueli181114
• rh-amarin

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main changes: fixing RabbitMQ deployment issues and performing cleanup of deprecated configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch HYPERFLEET-655/fix-rabbitmq-and-cleanup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@rafabene: This pull request references HYPERFLEET-655 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Fix values-rabbitmq.yaml: add missing broker.type: rabbitmq for sentinel (without this, sentinel defaults to googlepubsub and fails to start)
• Add default empty adapters.cluster and adapters.nodepool in base values (required by hyperfleet-api chart, prevents lint/deploy errors)
• Remove deprecated root Chart.yaml (never released, replaced by base+overlay pattern)
• Remove migration section from README referencing removed Chart.yaml

Found during

v0.1.0 release validation on GKE cluster.

Test plan

• make lint passes
• Deploy with values-rabbitmq.yaml and confirm sentinel starts with RabbitMQ broker
• Deploy with Pub/Sub and confirm all pods Running

Summary by CodeRabbit

• Chores

• Removed deprecated root Helm chart configuration, including all metadata and dependency declarations.

• Removed legacy chart migration guidance from documentation.

• New Features

• Extended configuration capabilities with new adapter parameters for cluster and nodepool components.

• Added explicit RabbitMQ broker type configuration option.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.